AppyxComponent state not restored after configuration changes #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KovalevAndrey
approved these changes
Apr 12, 2024
|
Update changelog pls |
manuel-martos
changed the title
|
|
||
| class NodeTest { | ||
| @Test | ||
| fun WHEN_node_is_create_THEN_plugins_are_setup_as_expected() { |
There was a problem hiding this comment.
let's add a test that verifies that onSavedInstanceState is called on AppyxComponent when Node is saving its state?
KovalevAndrey
approved these changes
Apr 12, 2024
| import org.junit.Test | ||
|
|
||
| class NodeTest { | ||
| private var appyxComponent: DummyComponent<RootNode.NavTarget>? = null |
There was a problem hiding this comment.
lateinit var can be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdif required.