Rename ParentNode & Node to Node and LeafNode #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsoltk
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...x-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/EmptyNodeViews.kt
Fixed
Show fixed
Hide fixed
...x-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/EmptyNodeViews.kt
Fixed
Show fixed
Hide fixed
...mon/src/commonMain/kotlin/com/bumble/appyx/navigation/composable/AppyxNavigationContainer.kt
Fixed
Show fixed
Hide fixed
appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/LeafNode.kt
Outdated
Show resolved
Hide resolved
KovalevAndrey
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ParentNodeis now simply calledNodeNodeclass is now calledLeafNode, but it's only a convenience class, and one can simply useNodein its place too. It does not add functionality just makes it easier to instantiateNodeif you don't need children.The updated migration guide shows the diff.
Check list
CHANGELOG.mdif required.