-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Gesture navigation API + swipe implementation #103
Conversation
...in/kotlin/com/bumble/appyx/navmodel/spotlight/gesturehandler/SpotlightSwipeGestureHandler.kt
Outdated
Show resolved
Hide resolved
Might be worth adding a video (when the PR is ready) to show how it works (with touches displayed) |
app/src/main/kotlin/com/bumble/appyx/app/node/onboarding/OnboardingContainerNode.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/com/bumble/appyx/app/node/onboarding/OnboardingContainerNode.kt
Fixed
Show fixed
Hide fixed
app/src/main/kotlin/com/bumble/appyx/app/node/onboarding/OnboardingContainerNode.kt
Fixed
Show fixed
Hide fixed
...rc/main/kotlin/com/bumble/appyx/core/navigation/gesture/swipe/SwipeGestureModifierFactory.kt
Show resolved
Hide resolved
Are you sure that is what we need? I imagined an implementation like in Telegram where a screen follows a finger. It would need to change |
We can discuss what we need but I can imaging it's a different API. The problem with this is that in |
@KovalevAndrey the gestures would be paired to a specific I think we could:
Possibly we could make all |
Closing for now as we're trying to implement a different approach for the way we handle transitions |
Description
Basic gesture API + Swipe implementation. Implemented as a Modifier which is applied to container composable.
If we agree on the API more gestures to come:
Fixes #97
device-2022-08-25-120746.mp4
Check list
CHANGELOG.md
if required.