Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): next #1485

Merged
merged 6 commits into from
Dec 20, 2023
Merged

feat(): next #1485

merged 6 commits into from
Dec 20, 2023

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Nov 30, 2023

Description

feat(TimePicker): Add Save and Cancel buttons to Time Picker #1481
feat(Picker): Specify parent of picker components #1483
fix(imask): upping the max date on all date/text masks from 2030 to 2100 #1486

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

* feat(TimePicker): Add Save and Cancel buttons to Time Picker

* TimePickerInput should emit save and cancel events as well
@dvoegelin dvoegelin self-assigned this Nov 30, 2023
Copy link
Contributor

github-actions bot commented Nov 30, 2023

Visit the preview URL for this PR (updated for commit 23c53ee):

https://novo-elements--pr1485-next-z8qtkabx.web.app

(expires Tue, 26 Dec 2023 21:48:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@dvoegelin dvoegelin merged commit 5a8e93f into master Dec 20, 2023
7 checks passed
@dvoegelin dvoegelin deleted the next branch December 20, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants