Restore JComboBox baseline calculation #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…two not deeded anymore variables.
|
Thank you Alex! |
jmborer
pushed a commit
to jmborer/Darcula
that referenced
this pull request
Nov 11, 2020
…llapse and split indication. Fixes bulenkov#18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding and changing the getDisplaySize method in DarculaComboBoxUI has the effect of defeating the combobox display size cache in the superclass and to interfere with the claculations in the getBaseline method.
Removing the overridden getDisplaySize seems to have no negative consequences on the widget painting and layouting and restores the ability of baseline aligning a combo box with other widgets.
Example using javax.swing.GroupLayout and baseline alignment, before:
After: