Repository navigation
feat: see exactly what telemetry and log bundles send - #154
Merged
Merged
Conversation
builtbyproxy
added this pull request to stack #150
October 7, 2026 13:39
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
2 times, most recently
from
October 8, 2026 02:18
d92bc42 to
3fd32dd
Compare
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
2 times, most recently
from
October 8, 2026 02:22
9c822d0 to
938ba2d
Compare
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
from
October 8, 2026 02:22
938ba2d to
ca1f5e3
Compare
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
4 times, most recently
from
October 8, 2026 02:32
ec0f0b9 to
dc93fd3
Compare
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
2 times, most recently
from
October 8, 2026 02:36
6c0132f to
7cd365a
Compare
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
from
October 8, 2026 02:39
7cd365a to
4c81e1b
Compare
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
from
October 8, 2026 02:41
4c81e1b to
402cfa5
Compare
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
from
October 8, 2026 02:44
402cfa5 to
2f643cd
Compare
… bundle sent to the developer
…eply, which can echo the review
… the answer to the opt-in notice
… is sent, regenerate the telemetry ID, and ask once about telemetry on the admin overview
…ce, exact error counts and the masked log bundle as they ship
…oted review out of a failed post's log, and send the bundle preview's note in a POST body
…ged, leave a very short review's error text intact, widen the email mask, and share one test logger
builtbyproxy
force-pushed
the
audit/stack-08-privacy-previews
branch
from
October 8, 2026 02:47
2f643cd to
d41bb0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 8 of the audit fix stack (releases 2.11.0, a minor feature release). Fixes audit findings DOC-1, DOC-2, DOC-3, SEC-7, SEC-8, SEC-10 and MNT-3. Stacked on #153.
New admin-only endpoint
POST Telemetry/RegenerateId;Telemetry/PreviewLogsmoves from GET to POST so the note never sits in a URL (it had no caller before).Release notes
You can now see exactly what Jellyscribe would send before anything leaves your server. In the admin settings, Integrations has a Preview of the anonymous telemetry ping, the exact JSON, with Copy and "Copy + regenerate ID" for bug reports, and a Regenerate ID button that gives your server a fresh anonymous identity whenever you like. The admin Overview asks once whether you would like to turn telemetry on, and never again after you answer. "Send to developer" on the Logs tab now has a Preview of the full bundle, your note included, and its confirmation lists everything the bundle holds. Email addresses no longer appear in Jellyscribe's logs or in a bundle: Serializd accounts are named by a short tag, and any address in older log lines is masked. A successful review's reply is no longer written to the log, and replies that older versions logged are cut from what you can send. The telemetry description is also more precise: usage counts are rough buckets, error counts are exact per week, and an extra ping goes out at most once a day when a new kind of error starts.
What's broken
GET Telemetry/Previewhas no caller, andBannerDismissedis never read.Why it happens
What this PR does
POST Telemetry/RegenerateId.BannerDismissed.serializd-3fa2b1), never by email.SerializdAccount.SerializdUsername.How it was tested
dotnet test: 1309 passed./jellyfin): 28 checks of the notice, Preview, Copy, Copy + regenerate, Regenerate with its confirm, and the bundle Preview. They ran with faked replies and against the real local endpoints, with config writes held in the browser, SendLogs blocked and telemetry left off on both servers.RegenerateIdreturns 403 to a non-admin and 401 anonymously.Screenshots
Taken on throwaway Jellyfin test servers with placeholder users and data; telemetry stayed off and nothing was sent.
Telemetry panel
Send to developer
Telemetry Preview
Regenerate ID confirm
Log bundle Preview (emails masked)
One-time telemetry question on the admin Overview