Repository navigation
ci: safer releases and download worker - #151
Merged
Merged
Conversation
… keep request logs off
…at repairs half-finished releases
…ions, keep the manifest sorted
builtbyproxy
force-pushed
the
audit/l09-ci-worker
branch
from
October 8, 2026 03:18
21cb1bd to
2ce9c59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the audit fix stack, but independent of the code layers (#144-#149), so it can merge any time. Fixes audit findings CI-1, CI-3, CI-4, CI-5, CI-7, CI-8, CI-9, CI-10, CI-14, SEC-11, SEC-12 and DOC-9.
Non-shipping: only .github/, worker/, tests and docs change, so no version bump and no release.
After merging, the worker changes only go live once someone runs
npx wrangler deployfromworker/.What's broken
manifest.jsonnever lists. Rerunning cannot fix it, because the workflow stops as soon as it sees the tag./dl/route is an open redirect. Encoded slashes and dot segments send a link on the project's download domain to any GitHub path.build.yaml.Why it happens
release.ymltreats "tag exists" as "release is done", runs without a concurrency group, and pushes the manifest without rebasing.contents: write.... It caps bundle size but not daily volume, and observability was left at its default.What this PR does
npx wrangler deployafter merge):/dl/only accepts<tag>/jellyfin-plugin-letterboxd-<tag>.zipon the raw path.build.yamlis removed.release-notes.tsstill say "cannot be linked across weeks" and need a separate wording fix.How it was tested
dotnet test -c Release --filter "FullyQualifiedName!~Integration": 1062 passed.node --experimental-strip-types --test worker/test/dl.test.mjs: 6 passed.manifest.jsonstill works.worker-testsjob.gh: