Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildpack api changes to support phase 1 of Dockerfiles implementation #307

Merged
merged 11 commits into from
Aug 23, 2022
Merged

Buildpack api changes to support phase 1 of Dockerfiles implementation #307

merged 11 commits into from
Aug 23, 2022

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Apr 15, 2022 •
edited
Loading

This would allow extensions to output a Dockerfile that can be used to switch the runtime base image only.

The extension phase is not needed as nothing is applied.

For further context, see this comment.

@natalieparellano natalieparellano requested a review from a team as a code owner April 15, 2022 19:49
natalieparellano
natalieparellano commented Apr 15, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Apr 15, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano force-pushed the extensions-buildpack-api branch 5 times, most recently from 6402e7f to d3a5b3d Compare April 15, 2022 20:05
@natalieparellano natalieparellano mentioned this pull request Apr 15, 2022
Merged
@natalieparellano
Buildpack api changes to support phase 1 of Dockerfiles implementation
9a5955f 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
This was referenced Apr 18, 2022
Closed
Closed
@natalieparellano natalieparellano mentioned this pull request Apr 27, 2022
Merged
@natalieparellano natalieparellano mentioned this pull request May 17, 2022
Closed
natalieparellano and others added 2 commits June 15, 2022 17:27
@natalieparellano
Updates from implementation
505b7d5 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@BarDweller
cache svgs and set svg bg to white (helps with github darkmode)
6f4a408 
Signed-off-by: BarDweller <bardweller@gmail.com>
@natalieparellano natalieparellano self-assigned this Jun 16, 2022
@natalieparellano natalieparellano mentioned this pull request Jun 23, 2022
Open
42 tasks
@natalieparellano
Merge pull request #315 from BarDweller/extensions-buildpack-api
4960f48 
cache svgs and set svg bg to white (helps with github darkmode)
jkutner
jkutner reviewed Jun 26, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
jkutner
jkutner reviewed Jun 26, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
jkutner
jkutner reviewed Jun 26, 2022
View reviewed changes
image_extension.md Outdated Show resolved Hide resolved
jkutner
jkutner reviewed Jun 26, 2022
View reviewed changes
image_extension.md Outdated Show resolved Hide resolved
jkutner
jkutner requested changes Jun 26, 2022
View reviewed changes
Copy link
Member

@jkutner jkutner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple small questions about word choice

@natalieparellano
Copy link
Member Author

Thanks @jkutner! I made some updates based on your feedback.

jkutner
jkutner reviewed Jun 27, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
jkutner
jkutner reviewed Jun 27, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano
Copy link
Member Author

natalieparellano commented Jun 27, 2022 •
edited
Loading

I rebased this onto #300 (since they are so interdependent, maybe it makes sense). But I can also put it back if that's easier to review.

It's probably better to merge #300 first so that the diff is easier to parse.

@natalieparellano
Update terminology section for image extensions
d6324b5 
Also make clear that generation is for extensions and build is for buildpacks

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano changed the base branch from buildpack/0.9 to buildpack-terminology June 27, 2022 19:39
@natalieparellano natalieparellano added this to the Buildpack 0.9 milestone Jun 29, 2022
@natalieparellano
Add nested output directories
ba59390 
A couple other small fixes.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Link to build plan
a2a0e2d 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Updates per 7/14 Working Group
e403a02 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Remove line describing build.toml left in by mistake
f905798 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Base automatically changed from buildpack-terminology to buildpack/0.9 August 23, 2022 08:53
@sambhav sambhav merged commit be79544 into buildpack/0.9 Aug 23, 2022
@sambhav sambhav deleted the extensions-buildpack-api branch August 23, 2022 08:54
@natalieparellano natalieparellano mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambhav sambhav sambhav approved these changes

@jkutner jkutner jkutner approved these changes

Assignees

@natalieparellano natalieparellano

Labels
None yet
Projects
None yet
Milestone
Buildpack 0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@natalieparellano @jkutner @sambhav @BarDweller