-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge cache and launch directories #28
Conversation
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of personal clarifications, but the big one is that I think the metadata can be simplified.
It's not necessarily specific to this change, but I'd prefer the
I believe this order puts the most significant arguments first, and improves the ergonomics of the API for the majority of buildpack authors (i.e. most buildpacks won't use There is nothing mechanically preventing a buildpack author from skipping over
It begs the question "what happened to $1 and $2" pretty early on when we're trying to ignore those args. If this is accepted, |
@jkutner I strongly disagree and think that value of the consistency in argument position (both detect and build need these arguments) is more valuable. |
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
I've approved this as-is, but would like to see #29 incorporated. |
Move layer argument to $1 for bin/build and bin/develop
Just a heads up as we do the merge into lifecycle, that the spec is still waiting on a couple of updates based on feedback. |
lifecycle changes implemented in buildpacks/lifecycle#45 |
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
872ea56
to
6a80698
Compare
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
Specifies #23.
Note: this further simplifies the initial proposal in #23 such that layers have three properties:
cache
build
launch
Such that cached launch layers are fully cache-coherent and always restored.