Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

As a pack CLI user, I must select a builder with: pack set-default-builder #36

Closed
sclevine opened this issue Jan 14, 2019 · 9 comments
Closed
Assignees
Labels

Comments

@sclevine
Copy link
Member

sclevine commented Jan 14, 2019

Acceptance Criteria
When I install the pack CLI on a workstation that has not had v0.1.0 installed at any point
And pack set-default-builder has not been run with pack v0.1.0
And I run pack build or pack run
Then I see:

Please select a default builder with:

pack set-default-builder [builder image]

Suggested builders:
  Cloud Foundry:  cloudfoundry/cnb
  Heroku:         heroku/buildpacks

Sample builders:
  Samples:        packs/samples

Notes:

  • suggestions are ordered randomly (except for Samples, which stays at the bottom)
  • After set-default-builder, do not show this message
  • May have to record the pack CLI version in the config file
@sclevine sclevine changed the title As a pack CLI user, I should be able to select a builder with: pack set-builder As a pack CLI user, I must select a builder with: pack set-default-builder Jan 23, 2019
@sclevine sclevine added size/1 and removed size/1 labels Jan 23, 2019
@ameyer-pivotal
Copy link

ameyer-pivotal commented Feb 5, 2019

To solution a tad, I think one way we could address this is to leave the initial default builder "", rather than populating it on first config load like we currently do. Then we can use "" to key off of for determining whether they need to select a default builder.

@sclevine
Copy link
Member Author

TODO: add more detail for each image (e.g., bionic vs. cflinuxfs3, buildpacks included), also recommend pack inspect-builder

ekcasey pushed a commit to buildpacks/pack that referenced this issue Mar 18, 2019
* pack build will provide suggestions if no default builder is set

[buildpacks/roadmap#36]

Signed-off-by: Danny Joyce <djoyce@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
@ekcasey
Copy link
Member

ekcasey commented Mar 18, 2019

This feature is essentially done in master of pack. However, I temporarily commented out the actual references to the suggested builders b/c neither currently work with master of pack

We should probably hold on acceptance until the builders work...

@djoyahoy djoyahoy self-assigned this Mar 19, 2019
@mgibson1121
Copy link
Member

mgibson1121 commented Mar 19, 2019

Per speaking with @djoyahoy, holding off testing this until the CF/heroku suggestions are truly randomized.

@ekcasey
Copy link
Member

ekcasey commented Mar 25, 2019

After discussion with @sclevine @nebhale @jkutner @hone It seems that we would like to take "Samples Builders", section out of the suggestions.

This raises an interesting question... our acceptance tests run against the samples builder, once the samples builder is no longer a default or even a suggested builder this doesn't seem as appropriate any more. What should we do instead?

Is testing against a builder created with pack create-builder sufficient? Should we also test that our suggested builders work? I think that would be probably be good for our users.

ekcasey added a commit to buildpacks/pack that referenced this issue Mar 28, 2019
* actually print suggested builders (builders are not guaranteed to work until pack beta release)

[buildpacks/roadmap#36]

Signed-off-by: Emily Casey <ecasey@pivotal.io>
@mgibson1121
Copy link
Member

mgibson1121 commented Mar 28, 2019

@ekcasey Is this story ready for acceptance? I recall during standup @sclevine mentioning a slightly more complex UX around randomly generating the order of the builders, but also grouping the CF builders together.

ekcasey added a commit to buildpacks/pack that referenced this issue Apr 1, 2019
* adds additional suggested builders
* adds description of suggested builders
* provide user with tip to try inspect-builder command

[buildpacks/roadmap#36]

Signed-off-by: Emily Casey <ecasey@pivotal.io>
@mgibson1121
Copy link
Member

@ekcasey @ameyer-pivotal @djoyahoy Any pointers for how to mimic this scenario on my machine? When I install the pack CLI on a workstation that has not had v0.1.0 installed at any point

@djoyahoy
Copy link
Member

djoyahoy commented Apr 2, 2019

@mgibson1121 you can delete the ~/.pack directory (rm -r ~/.pack) if it exists.

@mgibson1121
Copy link
Member

This passes acceptance

@sclevine sclevine closed this as completed Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants