Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stack/builders suggestions #330

Merged
merged 7 commits into from
Oct 7, 2019
Merged

Improve stack/builders suggestions #330

merged 7 commits into from
Oct 7, 2019

Conversation

dgageot
Copy link
Member

@dgageot dgageot commented Oct 4, 2019

  • Order stack/builders suggestions alphabetically
  • Move every stack under the Stacks maintained by the community category
  • Move code portions next to where they are used
  • Retrieve the builder descriptions concurrently
  • Simplify the code as much as I could

Fixes #311 and #329

@dgageot
Update suggest-stacks entries
9d49ede 
Fixes buildpacks#311

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Replace hard-coded output with template.
2095d3f 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Simplify code around suggested builders
92fac2e 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Move code next to where it’s used
a36e5f6 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Simplify code
4901c7e 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Fetch descriptions concurrently.
22282d4 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Order suggested builders/stacks alphabetically
a633381 
Fixes buildpacks#329

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot requested a review from a team as a code owner October 4, 2019 08:40
jromero
jromero approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

commands/suggest_builders.go Show resolved Hide resolved
@jromero jromero merged commit 59b0595 into buildpacks:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update suggest-stacks entries
2 participants
@dgageot @jromero