Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tar support for create-builder buildpacks #300

Merged
merged 1 commit into from
Sep 13, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions create_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ package pack
import (
"context"
"fmt"
"path/filepath"
"runtime"

"github.com/Masterminds/semver"
"github.com/buildpack/imgutil"
Expand Down Expand Up @@ -165,14 +163,6 @@ func validateBuilderConfig(conf builder.Config) error {
return errors.New("stack.run-image is required")
}

if runtime.GOOS == "windows" {
for _, bp := range conf.Buildpacks {
if filepath.Ext(bp.URI) != ".tgz" {
return fmt.Errorf("buildpack %s: directory-based buildpacks are not currently supported on Windows", style.Symbol(bp.ID))
}
}
}

return nil
}

Expand Down