pack build allows multiple --env-file
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jromero
reviewed
Sep 12, 2019
commands/build_test.go
Outdated
| "github.com/golang/mock/gomock" | ||
| "github.com/sclevine/spec" | ||
| "github.com/sclevine/spec/report" | ||
| "github.com/spf13/cobra" |
There was a problem hiding this comment.
Our format validation is failing on CI because these need to be broken up into 3 groups in this order:
- standard library
- 3rd party
- current project
If you are on MacOS or Linux you should be able to run make format.
There was a problem hiding this comment.
Thanks a lot! I've pushed a fix
Fix buildpacks#264 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
ekcasey
requested changes
Sep 13, 2019
| envPath = envfile.Name() | ||
| }) | ||
|
|
||
| it("builds an image with a builder", func() { |
There was a problem hiding this comment.
It would be better if the description strings in each it described what this particular test was asserting on (i.e. env vars in this case)
ekcasey
approved these changes
Sep 13, 2019
|
Thanks. I'm on it |
dgageot
added a commit
to dgageot/pack
that referenced
this pull request
Sep 13, 2019
Those are fixes to buildpacks#291: + Delete temp files after the test + Give better description for test cases Signed-off-by: David Gageot <david@gageot.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264