Improve error message when target architecture doesn't match daemon#2530
Draft
rohansood10 wants to merge 2 commits intobuildpacks:mainfrom
Draft
Improve error message when target architecture doesn't match daemon#2530rohansood10 wants to merge 2 commits intobuildpacks:mainfrom
rohansood10 wants to merge 2 commits intobuildpacks:mainfrom
Conversation
When saving a builder or buildpack to the local Docker daemon with a target that doesn't match the daemon's os/architecture, the error message was unclear about the root cause and offered no guidance. The improved error message now: - Shows the requested target(s) that don't match - Clearly states the daemon's os and architecture - Suggests using --publish flag with a registry as a workaround - Mentions that a local registry can be used for testing Fixes buildpacks#2428 Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
github-actions
bot
added
the
type/enhancement
When building in quiet mode, the containerd storage warning should not be displayed. This fix checks if quiet mode is enabled before printing the warning message. Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
rohansood10
force-pushed
the
fix/2428-improve-arch-mismatch-error
branch
from
64cd5ae to
768f23d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the error message when saving a builder or buildpack to the local Docker daemon with a target that doesn't match the daemon's os/architecture.
Before
After
Changes
daemonTarget()inpkg/client/package_buildpack.goto provide a more descriptive error message that includes the requested targets and suggests using--publishas a workaroundFixes #2428