Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zip-formatted files for the app path #234

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

jromero
Copy link
Member

@jromero jromero commented Jul 9, 2019

Resolves #106

Signed-off-by: Andrew Meyer ameyer@pivotal.io
Signed-off-by: Javier Romero jromero@pivotal.io

build.go Show resolved Hide resolved
@jromero jromero force-pushed the feature/106-zipped-app branch 3 times, most recently from 0c9440a to 3503eab Compare July 9, 2019 18:34
Copy link
Member

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small suggestions and questions we should discuss, but in general this looks good.

.travis.yml Show resolved Hide resolved
acceptance/acceptance_test.go Outdated Show resolved Hide resolved
build/phase.go Outdated Show resolved Hide resolved
internal/archive/archive.go Show resolved Hide resolved
build/phase.go Show resolved Hide resolved
build/phase.go Show resolved Hide resolved
build/phase.go Show resolved Hide resolved
build/phase.go Outdated Show resolved Hide resolved
acceptance/acceptance_test.go Outdated Show resolved Hide resolved
Also, disable redundant travis builds for PRs.

Resolves #106

Signed-off-by: Javier Romero <jromero@pivotal.io>
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
@ameyer-pivotal ameyer-pivotal merged commit 49dc406 into master Jul 10, 2019
@ameyer-pivotal ameyer-pivotal deleted the feature/106-zipped-app branch July 10, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a zip file of an app dir with pack build
4 participants