-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zip-formatted files for the app path #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jromero
commented
Jul 9, 2019
jromero
commented
Jul 9, 2019
jromero
force-pushed
the
feature/106-zipped-app
branch
3 times, most recently
from
July 9, 2019 18:34
0c9440a
to
3503eab
Compare
ekcasey
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small suggestions and questions we should discuss, but in general this looks good.
ekcasey
requested changes
Jul 10, 2019
ameyer-pivotal
force-pushed
the
feature/106-zipped-app
branch
from
July 10, 2019 20:36
62782e7
to
106a46d
Compare
ekcasey
approved these changes
Jul 10, 2019
ameyer-pivotal
force-pushed
the
feature/106-zipped-app
branch
from
July 10, 2019 21:05
106a46d
to
0176e3b
Compare
Also, disable redundant travis builds for PRs. Resolves #106 Signed-off-by: Javier Romero <jromero@pivotal.io> Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
ameyer-pivotal
force-pushed
the
feature/106-zipped-app
branch
from
July 10, 2019 21:27
0176e3b
to
ad9b416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #106
Signed-off-by: Andrew Meyer ameyer@pivotal.io
Signed-off-by: Javier Romero jromero@pivotal.io