Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust buildpacks in addition to those on the builder #2230

Conversation

AidanDelaney
Copy link
Member

@AidanDelaney AidanDelaney commented Jul 19, 2024

Trust buildpacks provided when --buildpack is provided on the command line.

Summary

Adds a --trust-extra-buiildpacks which applies to those buildpacks provided in addition to the buildpacks on a trusted builder.

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #2228

Trust buildpacks provided when `--buildpack` is provided on the
command line.

Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
@AidanDelaney AidanDelaney requested review from a team as code owners July 19, 2024 06:12
@github-actions github-actions bot added this to the 0.36.0 milestone Jul 19, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jul 19, 2024
@natalieparellano
Copy link
Member

Looks good to me. What do you think about --trust-extra-buildpacks as slightly less verbose?

@edmorley
Copy link
Contributor

Some other ideas to add to the pile :-)

  • --trust-external-buildpacks
  • --trust-all-buildpacks

@AidanDelaney
Copy link
Member Author

I think -extra- is the best describer. Will update.

Use the term "extra buildpacks" instead of "additional
buildpacks"

Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
@AidanDelaney AidanDelaney force-pushed the fix/2228-trust-additional-buildpacks branch from ed27d85 to b195e95 Compare July 22, 2024 04:58
@edmorley
Copy link
Contributor

edmorley commented Jul 25, 2024

Would it be possible to release this in a v0.35.1 release rather than waiting to v0.36.0 (which would presumably be further out)? :-)

(I've had to remain on Pack v0.34.x locally and in CI, since otherwise #2228 means our integration tests fail. I'd love to be able to update to pick up some of the other fixes in v0.35.0 like #2197 and #2205. With this PR released I could then update our test runner to set --trust-extra-buildpacks which would fix the tests.)

@natalieparellano
Copy link
Member

@edmorley I think we could cut a v0.35.1

@natalieparellano natalieparellano modified the milestones: 0.36.0, 0.35.1 Jul 25, 2024
@natalieparellano natalieparellano merged commit 2aa2cf5 into buildpacks:main Jul 25, 2024
16 checks passed
@edmorley
Copy link
Contributor

I think we could cut a v0.35.1

Thank you :-) Do you know when that might be?

@natalieparellano
Copy link
Member

@edmorley we could cut it this week. I want to also land these PRs: https://github.com/buildpacks/pack/milestone/56

(The amount of actual work required is very small)

@edmorley
Copy link
Contributor

That would be great! I know I don't have official review access, but I've reviewed those two open PRs in case it helps :-)

@edmorley
Copy link
Contributor

edmorley commented Aug 5, 2024

Thank you for the Pack 0.35.1 release :-)

@edmorley
Copy link
Contributor

edmorley commented Aug 27, 2024

@AidanDelaney I don't suppose you could update the PR description to match the updated arg name (--trust-extra-buildpacks)? I just copied the arg name from the current PR description (which has the old arg name) into several issues/PRs mistakenly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder no longer trusted when using --trust-builder with Pack 0.35.0
3 participants