Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/buildpacks/pack/issues/2164 #2165

Merged
merged 1 commit into from
May 23, 2024

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented May 23, 2024

Without this fix, CI will start failing when we upgrade to docker 25.x

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested review from a team as code owners May 23, 2024 15:35
@github-actions github-actions bot added this to the 0.34.0 milestone May 23, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.17%. Comparing base (4917cee) to head (113ba0c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2165      +/-   ##
==========================================
- Coverage   70.18%   70.17%   -0.01%     
==========================================
  Files         253      253              
  Lines       18449    18452       +3     
==========================================
  Hits        12947    12947              
- Misses       4656     4659       +3     
  Partials      846      846              
Flag Coverage Δ
os_linux 69.31% <0.00%> (+0.01%) ⬆️
os_macos 65.62% <0.00%> (-0.01%) ⬇️
os_windows 69.69% <0.00%> (-0.01%) ⬇️
unit 70.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natalieparellano natalieparellano merged commit f56bca5 into main May 23, 2024
17 of 18 checks passed
@natalieparellano natalieparellano deleted the fix/extensions-docker-25 branch May 23, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants