-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to override UID for container #2017
Conversation
Signed-off-by: Parthiba-Hazra <parthibahazra@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 79.50% 79.49% -0.01%
==========================================
Files 175 175
Lines 13114 13135 +21
==========================================
+ Hits 10425 10440 +15
- Misses 2022 2026 +4
- Partials 667 669 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
@Parthiba-Hazra - thanks a lot for this. Is it possible to add a test in lifecycle_execution_test.go? If you search for |
Signed-off-by: Parthiba-Hazra <parthibahazra@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Parthiba-Hazra great work! thank you!
Here in the pr I simply add a flag --uid to override uid for container and keep the implementation same as gid, as a new contributor to buildpack project I might be missing some points .. A swift review or guidance would greatly assist me in diving into this project.
Resolves #1347