Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use scafall for new extension #1685

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harikannan512
Copy link
Contributor

Summary

Add support for new comand for extensions using scafall

Output

Before

After

Documentation

Related

Resolves #1636

@harikannan512 harikannan512 requested review from a team as code owners March 26, 2023 20:46
@harikannan512 harikannan512 marked this pull request as draft March 26, 2023 20:46
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Mar 26, 2023
@github-actions github-actions bot added this to the 0.30.0 milestone Mar 26, 2023
Signed-off-by: Hari Kannan <harikannan512@gmail.com>
@harikannan512
Copy link
Contributor Author

@natalieparellano, a very early-stage question, but I just wanted to confirm if this is what you mean by using scafall. Should I implement a separate create command with scafall in addition to the old new command or should the new command use scafall as in this commit?

@natalieparellano natalieparellano modified the milestones: 0.30.0, 0.31.0 May 19, 2023
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@jjbustamante jjbustamante modified the milestones: 0.33.0, 0.32.0 Oct 31, 2023
@jjbustamante jjbustamante added the experimental Issue or PR refers to an experimental feature. label Nov 7, 2023
@jjbustamante jjbustamante removed this from the 0.33.0 milestone Nov 22, 2023
@jjbustamante
Copy link
Member

PR is still on draft, removing the milestone

@jjbustamante jjbustamante added this to the 0.35.0 milestone Mar 8, 2024
@natalieparellano natalieparellano modified the milestones: 0.35.0, 0.36.0 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Issue or PR refers to an experimental feature. type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pack should support pack extension new
3 participants