-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process specific working directories #1427
Add process specific working directories #1427
Conversation
0a006be
to
4e0d03f
Compare
Updating the PR soon, with passing test 😬 |
1076575
to
511d5a5
Compare
- Show process' working directory from the `WorkingDirectory` param in metadata label - If working directory from label is empty then use Image's inspect to figure out the working directory (stored as WorkingDir) Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
511d5a5
to
1c3bab2
Compare
|
35e469d
to
e4e8e58
Compare
Hey @jromero, I am having issues with the spacing for |
I can see the issue in Windows. It looks as though because Based on our conversation on In otherwords, deleting these lines (L976-L980, L1627-L1631) and any associated resources from |
e4e8e58
to
87725ef
Compare
Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
87725ef
to
39ffe82
Compare
Summary
WorkingDirectory
param in metadata labelThis PR depends on Add
WorkingDir()
to return image working directory imgutil#141, I did not find a way to expose the working directory so I had to go for this change, let me know if there's another way to handle the problem.Moreover, I had to update a bunch of dependencies to actually get the newly added
WorkingDirectory
param inside ofprocess
, which meansgo.mod
andgo.sum
are modified.I think we'll need to update the PR again with the new
imgutil
release if we decide to merge both PRs and go this route, if not then I'd be happy to work on the feedback.Tests will be failing until we merge the PR for
imgutil
Output
Before
After
Documentation
Related
#1422
Resolves #1422