Set SOURCE_DATE_EPOCH #1418

natalieparellano · 2022-04-11T22:22:36Z

pack should set SOURCE_DATE_EPOCH in exporter's env if --creation-time flag is provided

Also bumps default lifecycle version

Before

Image create time is always Jan 1, 1980

After

Image create time is configurable

Documentation

Should this change be documented?
- Yes, see #___
- No

Codecov Report

Merging #1418 (34ff550) into main (b9be13a) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

❗ Current head 34ff550 differs from pull request most recent head 26c6f36. Consider uploading reports for the commit 26c6f36 to get more accurate results

@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   81.27%   81.27%   -0.00%     
==========================================
  Files         151      151              
  Lines        9715     9745      +30     
==========================================
+ Hits         7895     7919      +24     
- Misses       1346     1350       +4     
- Partials      474      476       +2

Flag	Coverage Δ
os_linux	`80.02% <80.00%> (-<0.01%)`	⬇️
os_macos	`77.40% <80.00%> (-0.02%)`	⬇️
os_windows	`81.14% <80.00%> (-<0.01%)`	⬇️
unit	`81.27% <80.00%> (-<0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

sambhav · 2022-04-11T23:09:18Z

Should the flag instead be --creation-time?

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano · 2022-04-12T15:33:34Z

Phew! Finally green...

jromero

Two minor points:

We should probably cary the term CreationTime across the entire code base instead of having an ambiguous DateTime
Isn't this variable only respected on newer Platform API versions? If so, it seems like we should only be passing it to the container in those cases and warning the user if it's not applicable.

internal/commands/build.go

dfreilich

Overall, as always, beautiful! just a few tweaks would be awesome

internal/commands/build.go

Signed-off-by: Natalie Arellano <narellano@vmware.com>

…en platform api is 0.9 Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano · 2022-04-13T14:39:07Z

The tests are green but I don't understand why - https://github.com/buildpacks/pack/runs/6009113466?check_suite_focus=true uses a lifecycle that doesn't support this feature. Investigating.

dfreilich

Fantastic!

dfreilich · 2022-04-13T14:38:47Z

acceptance/acceptance_test.go

+						})
+
+						when("not provided", func() {
+							it("image has create time of Jan 1, 1980", func() {


This test could actually run in all compatibility cases, but I'm not sure whether it's worth the time cost of having the tests do that.

…n time Signed-off-by: Natalie Arellano <narellano@vmware.com>

Jan 1, 1980 is always going to be less than a time of about now Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano · 2022-04-13T14:54:01Z

The tests are green but I don't understand why - https://github.com/buildpacks/pack/runs/6009113466?check_suite_focus=true uses a lifecycle that doesn't support this feature. Investigating.

I found the issue - fixed in c23e970 (it was a bad assertion).

thedevelopnik · 2022-05-24T20:55:56Z

Thank you so much! This is a long-awaited feature and I am so grateful it landed!

pack should set SOURCE_DATE_EPOCH in exporter's env if --date-time fl…

2fc8691

…ag is provided Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano requested a review from a team as a code owner April 11, 2022 22:22

github-actions bot added this to the 0.25.0 milestone Apr 11, 2022

github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Apr 11, 2022

natalieparellano added 2 commits April 12, 2022 10:36

Fix compat test and add coverage

08bf823

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Change --date-time to --creation-time

6612105

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano changed the title ~~pack should set SOURCE_DATE_EPOCH in exporter's env if --date-time flag is provided~~ pack should set SOURCE_DATE_EPOCH in exporter's env if --creation-time flag is provided Apr 12, 2022

Fix skip

5b29c8b

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the source-date-epoch branch from 9e16eaa to 5b29c8b Compare April 12, 2022 15:10

jromero suggested changes Apr 12, 2022

View reviewed changes

internal/commands/build.go Show resolved Hide resolved

dfreilich requested changes Apr 13, 2022

View reviewed changes

internal/commands/build.go Outdated Show resolved Hide resolved

internal/commands/build.go Show resolved Hide resolved

natalieparellano added 2 commits April 13, 2022 09:42

Update var name and add accepted values to help text

644710f

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Add 0.9 to supported platform apis and only pass SOURCE_DATE_EPOCH wh…

34ff550

…en platform api is 0.9 Signed-off-by: Natalie Arellano <narellano@vmware.com>

dfreilich approved these changes Apr 13, 2022

View reviewed changes

natalieparellano added 2 commits April 13, 2022 10:40

Skip acceptance test if lifecycle doesn't support customizing creatio…

26c6f36

…n time Signed-off-by: Natalie Arellano <narellano@vmware.com>

Fix assertions

c23e970

Jan 1, 1980 is always going to be less than a time of about now Signed-off-by: Natalie Arellano <narellano@vmware.com>

jromero changed the title ~~pack should set SOURCE_DATE_EPOCH in exporter's env if --creation-time flag is provided~~ Set SOURCE_DATE_EPOCH Apr 13, 2022

jromero mentioned this pull request Apr 13, 2022

Support Platform API 0.9 #1421

Closed

4 tasks

dfreilich modified the milestones: 0.25.0, 0.26.0 Apr 15, 2022

jromero approved these changes Apr 20, 2022

View reviewed changes

jromero merged commit 8921b1b into main Apr 20, 2022

jromero deleted the source-date-epoch branch April 20, 2022 17:21

jromero removed the type/chore Issue that requests non-user facing changes. label Jun 10, 2022

schneems mentioned this pull request Oct 10, 2024

Investigate FIFO asset cache cleaner with Pack creation time behavior heroku/buildpacks-ruby#302

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set SOURCE_DATE_EPOCH #1418

Set SOURCE_DATE_EPOCH #1418

natalieparellano commented Apr 11, 2022 •

edited

Loading

codecov bot commented Apr 11, 2022 •

edited

Loading

sambhav commented Apr 11, 2022

natalieparellano commented Apr 12, 2022

jromero left a comment

dfreilich left a comment

natalieparellano commented Apr 13, 2022

dfreilich left a comment

dfreilich Apr 13, 2022

natalieparellano commented Apr 13, 2022

thedevelopnik commented May 24, 2022

Set SOURCE_DATE_EPOCH #1418

Set SOURCE_DATE_EPOCH #1418

Conversation

natalieparellano commented Apr 11, 2022 • edited Loading

Before

After

Documentation

Related

codecov bot commented Apr 11, 2022 • edited Loading

Codecov Report

sambhav commented Apr 11, 2022

natalieparellano commented Apr 12, 2022

jromero left a comment

Choose a reason for hiding this comment

dfreilich left a comment

Choose a reason for hiding this comment

natalieparellano commented Apr 13, 2022

dfreilich left a comment

Choose a reason for hiding this comment

dfreilich Apr 13, 2022

Choose a reason for hiding this comment

natalieparellano commented Apr 13, 2022

thedevelopnik commented May 24, 2022

natalieparellano commented Apr 11, 2022 •

edited

Loading

codecov bot commented Apr 11, 2022 •

edited

Loading