Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssh-agent connection on Windows #1353

Merged
merged 7 commits into from
Jan 24, 2022

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek matejvasek requested a review from a team as a code owner January 5, 2022 17:55
@github-actions github-actions bot added this to the 0.24.0 milestone Jan 5, 2022
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Jan 5, 2022
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #1353 (8c3872b) into main (d6272a2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
+ Coverage   81.53%   81.54%   +0.02%     
==========================================
  Files         146      148       +2     
  Lines        9568     9575       +7     
==========================================
+ Hits         7800     7807       +7     
  Misses       1303     1303              
  Partials      465      465              
Flag Coverage Δ
os_linux 80.27% <100.00%> (+0.03%) ⬆️
os_macos 77.64% <100.00%> (+0.04%) ⬆️
os_windows 81.41% <100.00%> (+0.05%) ⬆️
unit 81.54% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

@jromero @aemengo PTAL

@aemengo
Copy link
Contributor

aemengo commented Jan 13, 2022

@matejvasek have you already given this a look on a Windows machine? The project has some.

@matejvasek
Copy link
Contributor Author

@aemengo I have not, but colleague of mine @jrangelramos developed and tested this on some Windows VM.
See also knative/func#733

@jrangelramos
Copy link

+1
I applied and tested similar fix on func. It works as expected.

Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help with this!

@dfreilich dfreilich merged commit cfbade5 into buildpacks:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants