Fix default buildpack API version. #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was incorrectly pulling the latest supported platform API version. Explicitly declare the default version instead of dynamically pulling, as updates may require changes to the buildpack tempalte. Signed-off-by: Mikey Boldt <mboldt@vmware.com>
github-actions
bot
added
the
type/enhancement
jromero
added
type/bug
jromero
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix default buildpack API version in
pack buildpack newIt was incorrectly pulling the latest supported platform API version.
Explicitly declare the default version instead of dynamically pulling,
as updates may require changes to the buildpack tempalte.
I chose version 0.5 since that is what is declared in the main branch of the spec. There is also a buildpack spec 0.6 tag (which still declares it's version 0.5) and even a reference to buildpack API 0.7 in lifecycle; happy to use a different version based on feedback.
Output
When generating a buildpack with
pack buildpack newwithout specifying a buildpack API version:Before
In buildpack.toml:
After
In buildpack.toml:
Documentation
Related
Slack discussion of this.
I don't know if the generated buildpack is currently compatible with all supported buildpack API versions, but if we need slight differences based on the specified buildpack API version, that could be a follow-on to this.