Pass previous-image to analyzer #1279
Conversation
github-actions
bot
added
the
type/enhancement
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
- Coverage 81.07% 80.18% -0.89%
==========================================
Files 143 143
Lines 8737 8760 +23
==========================================
- Hits 7083 7023 -60
- Misses 1216 1281 +65
- Partials 438 456 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Thanks for the help, @importhuman! This looks super neat.
Can you just validate this with a unit test? 🚀
|
@dfreilich yup, tests are still to come! |
|
@dfreilich just to confirm, we don't need to do anything in this PR to check if the builder is trusted or not, correct? |
|
I'll check if any more tests are required in |
importhuman
force-pushed
the
update-previous-image
branch
from
8389145
to
578c2d6
Compare
See buildpacks#897, buildpacks#1275 Signed-off-by: Ujjwal Goyal <importujjwal@gmail.com>
This commit adds tests for passing previous-image to analyzer, with some modifications to the naming of earlier tests for passing the flag to creator. Also modifies "opts" to "Opts" in LifecycleExecution to make it accessible to the test; other changes maintain this change across the repository. Closes buildpacks#1275 Signed-off-by: Ujjwal Goyal <importujjwal@gmail.com>
Signed-off-by: Ujjwal Goyal <importujjwal@gmail.com>
This commit adds getters for lifecycle image and previous image, and updates the previous-image unit tests using them. Also reverts "Opts" to "opts" in LifecycleExecution across the repo where applicable (from an earlier commit). Closes buildpacks#1275 Signed-off-by: Ujjwal Goyal <importujjwal@gmail.com>
importhuman
force-pushed
the
update-previous-image
branch
from
09596bd
to
8b39564
Compare
|
@jromero implemented it like you said, and have reverted the changes I'd made earlier from LifecycleExecution. |
|
@buildpacks/platform-maintainers can you please let me know if something else is needed? |
|
Apologies for the delay. LGTM. |
|
🙏 Thank you for the contribution! Keep it up! |
See #897, #1275
Signed-off-by: Ujjwal Goyal importujjwal@gmail.com
Summary
Initial commit for passing previous-image to analyzer. I wasn't completely sure how to provide it to analyzer, so I've added it to the slice of arguments.
Documentation