Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make workspace configurable #1149

Merged
merged 7 commits into from
May 19, 2021
Merged

Make workspace configurable #1149

merged 7 commits into from
May 19, 2021

Conversation

dwillist
Copy link
Contributor

@dwillist dwillist commented Apr 29, 2021 •
edited by dfreilich
Loading

Signed-off-by: dwillist dthornton@vmware.com

Summary

follow up PR for #1121 that just adds lifecycle -app argument for the phases that require it & sorts out permissions on newly mounted directory.

Documentation

  • Should this change be documented?
    • No?

Related

#1121
Updates #1141

@dwillist dwillist requested a review from a team as a code owner April 29, 2021 06:28
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Apr 29, 2021
@dwillist dwillist force-pushed the configure_workspace branch 2 times, most recently from ab31dff to 57fb602 Compare April 29, 2021 15:32
@codecov
Copy link

codecov bot commented Apr 29, 2021 •
edited
Loading

Codecov Report

Merging #1149 (e1a35f2) into main (7632bf9) will increase coverage by 0.01%.
The diff coverage is 88.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   80.83%   80.83%   +0.01%     
==========================================
  Files         136      136              
  Lines        8278     8294      +16     
==========================================
+ Hits         6691     6704      +13     
- Misses       1159     1161       +2     
- Partials      428      429       +1
Flag Coverage Δ
os_linux 80.39% <90.48%> (+0.02%) ⬆️
os_macos 77.97% <80.96%> (+0.02%) ⬆️
os_windows 80.75% <88.89%> (+0.01%) ⬆️
unit 80.44% <90.48%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dwillist dwillist force-pushed the configure_workspace branch 3 times, most recently from 5996ea2 to d87bd06 Compare April 29, 2021 16:13
@dwillist
add lifecycle args & permissions changes so that application source c…
35ed268 
…ode can be added at places other than workspace

Signed-off-by: dwillist <dthornton@vmware.com>
@dwillist dwillist added type/bug Issue that reports an unexpected behaviour. and removed type/chore Issue that requests non-user facing changes. labels Apr 29, 2021
@dfreilich dfreilich mentioned this pull request Apr 29, 2021
Closed
2 tasks
@jkutner
Copy link
Member

jkutner commented Apr 29, 2021

@dwillist thank you!

@github-actions github-actions bot added this to the 0.19.0 milestone Apr 29, 2021
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Apr 29, 2021
dfreilich
dfreilich approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfreilich dfreilich removed the type/chore Issue that requests non-user facing changes. label May 19, 2021
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label May 19, 2021
@dfreilich dfreilich changed the title some additional changes needed to make workspace configurable. Make workspace configurable May 19, 2021
@dfreilich dfreilich removed type/chore Issue that requests non-user facing changes. type/bug Issue that reports an unexpected behaviour. labels May 19, 2021
@dfreilich dfreilich merged commit 216a4d1 into main May 19, 2021
@dfreilich dfreilich deleted the configure_workspace branch May 19, 2021 07:52
@jromero
Copy link
Member

jromero commented Jun 16, 2021

@dwillist this change appears to have brought up some questions. Can you provide a bit of explanation as to why the root needed to change permission?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreilich dfreilich dfreilich approved these changes

Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dwillist @jkutner @jromero @dfreilich