Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heroku-20 to suggested stacks list #1122

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Mar 30, 2021

Summary

Heroku-20 is now Heroku's default stack, and was previously added to the suggested builders list in #1052, however was not yet listed in the suggested stacks list.

See:
https://github.com/heroku/pack-images#heroku-pack-base-images

Output

Before

$ pack stack suggest
Stacks maintained by the community:

    Stack ID: heroku-18
    Description: The official Heroku stack based on Ubuntu 18.04
    Maintainer: Heroku
    Build Image: heroku/pack:18-build
    Run Image: heroku/pack:18

    Stack ID: io.buildpacks.stacks.bionic
    Description: A minimal Paketo stack based on Ubuntu 18.04
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:base-cnb
    Run Image: paketobuildpacks/run:base-cnb

    Stack ID: io.buildpacks.stacks.bionic
    Description: A large Paketo stack based on Ubuntu 18.04
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:full-cnb
    Run Image: paketobuildpacks/run:full-cnb

    Stack ID: io.paketo.stacks.tiny
    Description: A tiny Paketo stack based on Ubuntu 18.04, similar to distroless
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:tiny-cnb
    Run Image: paketobuildpacks/run:tiny-cnb

After

$ go run cmd/pack/main.go stack suggest
Stacks maintained by the community:

    Stack ID: heroku-18
    Description: The official Heroku stack based on Ubuntu 18.04
    Maintainer: Heroku
    Build Image: heroku/pack:18-build
    Run Image: heroku/pack:18

    Stack ID: heroku-20
    Description: The official Heroku stack based on Ubuntu 20.04
    Maintainer: Heroku
    Build Image: heroku/pack:20-build
    Run Image: heroku/pack:20

    Stack ID: io.buildpacks.stacks.bionic
    Description: A minimal Paketo stack based on Ubuntu 18.04
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:base-cnb
    Run Image: paketobuildpacks/run:base-cnb

    Stack ID: io.buildpacks.stacks.bionic
    Description: A large Paketo stack based on Ubuntu 18.04
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:full-cnb
    Run Image: paketobuildpacks/run:full-cnb

    Stack ID: io.paketo.stacks.tiny
    Description: A tiny Paketo stack based on Ubuntu 18.04, similar to distroless
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:tiny-cnb
    Run Image: paketobuildpacks/run:tiny-cnb

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Heroku-20 is now Heroku's default stack, and was previously
added to the suggested builders list in buildpacks#1052, however was
was not yet listed in the suggested stacks list.

See:
https://github.com/heroku/pack-images#heroku-pack-base-images

Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@edmorley edmorley requested a review from a team as a code owner March 30, 2021 14:48
@github-actions github-actions bot added this to the 0.18.0 milestone Mar 30, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1122 (787d4aa) into main (aa49ae6) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   80.54%   80.02%   -0.51%     
==========================================
  Files         136      136              
  Lines        8251     6010    -2241     
==========================================
- Hits         6645     4809    -1836     
+ Misses       1176      767     -409     
- Partials      430      434       +4     
Flag Coverage Δ
os_linux 80.02% <ø> (+0.05%) ⬆️
os_macos 77.54% <ø> (ø)
os_windows ∅ <ø> (∅)
unit 80.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero jromero modified the milestones: 0.18.0, 0.19.0 Mar 30, 2021
@dfreilich dfreilich merged commit 323a48b into buildpacks:main Apr 5, 2021
@edmorley edmorley deleted the stack-suggest-heroku-20 branch April 5, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants