-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move inspect-builder and inspect-buildpack to relevant subcommands #1071
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1071 +/- ##
==========================================
+ Coverage 80.38% 80.51% +0.13%
==========================================
Files 133 135 +2
Lines 8170 8221 +51
==========================================
+ Hits 6567 6618 +51
Misses 1174 1174
Partials 429 429
Flags with carried forward coverage won't be shown. Click here to find out more. |
imageName := cfg.DefaultBuilder | ||
if len(args) >= 1 { | ||
imageName = args[0] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was previously an undocumented feature. I've added it to the long description of the command now.
buildpackName := args[0] | ||
registry := flags.Registry | ||
if registry == "" { | ||
registry = cfg.DefaultRegistryName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a slight change of behavior – in inspect-builder
, it checks the configs default-registry, rather than default-registry-name, but given that default-registry
is deprecated, I thought it appropriate to use the newer default-registry-name
for the updated command.
* Remove trust-builder, untrust-builder, and list-trusted-builders acceptance tests (they are currently tested under the config when block * Move inspect-buildpack into the buildpack block, to allow for easier restructuring for #1071 Signed-off-by: David Freilich <dfreilich@vmware.com>
…uilder and inspect-buildpack commands * Rename inspect-image to inspect, and add alias for inspect-image * Change behavior for inspect-buildpack to look at default registry name in config, rather than deprecated default registry Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
22693e8
to
c989332
Compare
Signed-off-by: David Freilich <dfreilich@vmware.com>
c989332
to
b7711d1
Compare
Signed-off-by: David Freilich <dfreilich@vmware.com>
last := len(parts) - 1 | ||
cmdParts = append(cmdParts, parts[:last]...) | ||
search = parts[last] | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was to enable seeing whether pack supports a top-level command, which otherwise didn't work appropriately.
Summary
Output
Before
After
Documentation
Related
Resolves #920
Resolves #597 (finally)