Close response body after use when caching downloaded buildpacks

Hopefully fixes #97
buildpacks · Feb 11, 2019 · 6ad116d · 6ad116d
1 parent eaae38c
commit 6ad116d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/builder_factory.go b/builder_factory.go
@@ -153,6 +153,12 @@ func (f *BuilderFactory) resolveBuildpackURI(builderDir string, b Buildpack) (Bu
 			dir = cachedDir
 			break
 		} else {
+			defer func() {
+				err := reader.Close()
+				if err != nil {
+					fmt.Printf("warning: could not close %v: %s", reader, err)
+				}
+			}()
 			if err = f.untarZ(reader, cachedDir); err != nil {
 				return Buildpack{}, err
 			}
@@ -324,7 +330,7 @@ func (f *BuilderFactory) latestLayer(buildpacks []Buildpack, dest, builderDir st
 	return tarFile, err
 }
 
-func (f *BuilderFactory) downloadAsStream(uri string, etag string) (io.Reader, string, error) {
+func (f *BuilderFactory) downloadAsStream(uri string, etag string) (io.ReadCloser, string, error) {
 	c := http.Client{}
 	req, err := http.NewRequest("GET", uri, nil)
 	if err != nil {