Bumps imgutil to pick up layout package refactor & local package fix … #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalieparellano
commented
Feb 5, 2024
| @@ -487,7 +487,7 @@ func testAnalyzerFunc(platformAPI string) func(t *testing.T, when spec.G, it spe | |||
| analyzer := assertAnalyzedMetadata(t, filepath.Join(copyDir, "analyzed.toml")) | |||
| h.AssertNotNil(t, analyzer.RunImage) | |||
| analyzedImagePath := filepath.Join(path.RootDir, "layout-repo", "index.docker.io", "library", "busybox", "latest") | |||
| reference := fmt.Sprintf("%s@%s", analyzedImagePath, "sha256:834f8848308af7090ed7b2270071d28411afc42078e3ba395b1b0a78e2f8b0e2") | |||
| reference := fmt.Sprintf("%s@%s", analyzedImagePath, "sha256:f75f3d1a317fc82c793d567de94fc8df2bece37acd5f2bd364a0d91a0d1f3dab") | |||
There was a problem hiding this comment.
The previous version of imgutil did not have buildpacks/imgutil#233 and so we mutated the media types, mutating the digest
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 56.71% 64.16% +7.46%
==========================================
Files 93 99 +6
Lines 6650 6858 +208
==========================================
+ Hits 3771 4400 +629
+ Misses 2531 2061 -470
- Partials 348 397 +49
Flags with carried forward coverage won't be shown. Click here to find out more. |
…for containerd storage Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
bump-imgutil
branch
from
3f72c5f
to
b1b8b69
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
IDK, I think Codecov is being too picky here |
jabrown85
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release notes
Fixes export to docker daemon when containerd storage is enabled
Related
Resolves buildpacks/pack#1519
Context