docs: mention docker:// as supported lifecycle URI #855
+36
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
AidanDelaney
requested changes
Oct 21, 2025
| ### Supported archives | ||
|
|
||
| Currently, when specifying a URI to a buildpack or lifecycle, only `tar` or `tgz` archive types are supported. | ||
| Currently, a URI to a buildpack or lifecycle supports `tar`, `tgz`, or `docker://` archive types. |
There was a problem hiding this comment.
I think the original sentence is poorly specified. The supported archive types re tar and tgz. But the uri's are either on-disk or a docker://. Do we need to expand this explanation here?
There was a problem hiding this comment.
Thank you for the feedback, Aidan. I'll review and update this section within the next few days. Thanks for the review again.
There was a problem hiding this comment.
Hi Aidan, I have raised a new PR #863, that fixes this issue.
Signed-off-by: Robert Gogolok <robert.gogolok@stackit.cloud>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aidan Delaney <adelaney21@bloomberg.net>
Bumps [buildpacks/github-actions](https://github.com/buildpacks/github-actions) from 5.9.3 to 5.9.5. - [Release notes](https://github.com/buildpacks/github-actions/releases) - [Commits](buildpacks/github-actions@v5.9.3...v5.9.5) --- updated-dependencies: - dependency-name: buildpacks/github-actions dependency-version: 5.9.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aidan Delaney <adelaney21@bloomberg.net>
Only include those files that the developer has changed in the vale lint. This will remove the need to fix _all_ the problems in content on every commit. Signed-off-by: adelaney21 <adelaney21@bloomberg.net>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
|
Just the DCO now! |
|
Hey Aidan, I opened a new PR for this issue, #863, it has passed all the vale checks and DCO we could merge that maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the docs to include
docker://as an additional supported lifecycle URI.Closes #850