-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand buildpack author concepts pages #739
Expand buildpack author concepts pages #739
Conversation
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@AidanDelaney @natalieparellano still waiting for your review? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, this is great. I have a few small comments where we might provide clarification to buildpack authors. Feel free to comment on why my clarifications might not make sense!
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @hyounes4560! It's really cool to see this coming along. I left some comments and some longer explanations where we could flesh things out more. LMK what you think!
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
* adds some build plan content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * edits MD styling Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds component buildpack content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds some dependency layer content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds buildpack package content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds reviewer feedback Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds 2nd reviewer feedback Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * Adds some links Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * updates dependency layer page Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds pages linking Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds more build-plan and layers content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> --------- Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> Co-authored-by: Aidan Delaney <adelaney21@bloomberg.net>
Expand buildpack author concepts pages
exec.d page
closes #740