Don't run if CI isn't set #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should quiet these warnings when running pytest locally on developer machines outside of CI: ``` buildkite-test-collector - WARNING - No BUILDKITE_ANALYTICS_TOKEN environment variable present ``` Based on the README, I think this was already the intent: > Run your tests like normal. Note that we attempt to detect the presence of several common CI environments, however if this fails you can set the `CI` environment variable to any value and it will work.
nprizal
requested changes
Jul 29, 2025
There was a problem hiding this comment.
Hi @jmsanders, thanks for opening the PR.
We’ve intentionally removed the CI env requirements (see #46) because we want the collector to run outside of CI for debugging purpose. Your changes only skip the upload process when the CI env is missing, which is a valid case. I'm happy with the changes, but could you please rename the variable to ENV_CI for clarity?
| @@ -12,20 +12,26 @@ | |||
| class API: | |||
| """Buildkite Test Engine API client""" | |||
|
|
|||
| CI_TOKEN = "CI" | |||
There was a problem hiding this comment.
Suggested change
| CI_TOKEN = "CI" | |
| ENV_CI = "CI" |
| ENV_TOKEN = "BUILDKITE_ANALYTICS_TOKEN" | ||
| ENV_API_URL = "BUILDKITE_ANALYTICS_API_URL" | ||
|
|
||
| DEFAULT_API_URL = "https://analytics-api.buildkite.com/v1" | ||
|
|
||
| def __init__(self, env: Mapping[str, Optional[str]]): | ||
| """Initialize the API client with environment variables""" | ||
| self.ci = env.get(self.CI_TOKEN) |
There was a problem hiding this comment.
Suggested change
| self.ci = env.get(self.CI_TOKEN) | |
| self.ci = env.get(self.ENV_CI) |
|
Sure thing - changed. |
nprizal
approved these changes
Jul 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should quiet these warnings when running pytest locally on developer machines outside of CI:
Based on the README, I think this was already the intent: