Enable experimental docker cli in the environment hook #911
Conversation
| @@ -10,6 +10,11 @@ BUILDKITE_DOCKER_CONFIG_TEMP_DIRECTORY=$(mktemp -d) | |||
| export BUILDKITE_DOCKER_CONFIG_TEMP_DIRECTORY | |||
| export DOCKER_CONFIG="$BUILDKITE_DOCKER_CONFIG_TEMP_DIRECTORY" | |||
|
|
|||
| if [ "${BUILDKITE_DOCKER_EXPERIMENTAL:-false}" = "true" ] | |||
| then | |||
| cat <<< "$(jq '.experimental="enabled"' "${DOCKER_CONFIG}/config.json")" > "${DOCKER_CONFIG}/config.json" | |||
There was a problem hiding this comment.
This pattern is used elsewhere in the codebase without issue.
Knowing about the truncation issue I was curious whether this would work when writing it. I’ve confirmed that the multiple edits in the above link are preserved, that the former edit isn’t truncated to zero and overwritten by the latter edit.
I’d like to confirm why this is working before moving ahead with a #shellcheck disable=SC2094
There was a problem hiding this comment.
This pattern seems to come from this long standing issue https://github.com/stedolan/jq/issues/105#issuecomment-437363987 in jq asking for edit in place.
There was a problem hiding this comment.
I reckon this must be fine because it is redirects in a single command which bash processes in order rather than redirects in separate commands in a pipeline which are processed in parallel and race.
Save the value of the
EnableDockerExperimentalparameter in~/cfn-envfor the environment hook to use. In the environment hook, set$DOCKER_CONFIG/config.json.experimental="enabled".Fixes #798