Add cross-parameter rules #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithduncan
force-pushed
the
keithduncan/add-rules
branch
from
0d131d0 to
2e3dc92
Compare
keithduncan
force-pushed
the
keithduncan/add-rules
branch
from
6876ee1 to
3274d31
Compare
|
Sadly I couldn’t get validation of the VPC Parameters working because the stack parameters are optional and thus untyped, disabling the use of the Also sadly the validation still happens quite late in the template apply process, I had hoped it would be run at the parameter input stage before progressing.
The benefit of this change is it now tells you what you are missing since we can’t make either of the token parameters required while both are supported. |
yob
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Rulessection to validate cross-parameter values:Fixes #648