Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IAM roles for SNS and SQS #829

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Remove IAM roles for SNS and SQS #829

merged 1 commit into from
Apr 28, 2021

Conversation

chloeruka
Copy link
Contributor

These appear to be vestigial since we no longer use SNS/SQS queue for agent lifecycle operations when we removed that for lifecycled in #135.

These appear to be vestigial since we no longer use SNS/SQS queue for agent lifecycle operations when we removed that for LifecycleD in #135.
@chloeruka chloeruka requested review from sj26, pda and yob April 27, 2021 05:47
@sj26
Copy link
Member

sj26 commented Apr 27, 2021

I think we are using lifecycled again, but without the SNS/SQS part, only to handle graceful termination:
https://github.com/buildkite/elastic-ci-stack-for-aws/blob/master/packer/linux/scripts/install-lifecycled.sh
https://github.com/buildkite/elastic-ci-stack-for-aws/blob/master/packer/linux/conf/bin/bk-install-elastic-stack.sh#L141-L148

So I believe it's safe to remove these permissions. Nice.

We should upgrade out own stack after merging to be really sure.

Copy link
Contributor

@yob yob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I believe it's safe to remove these permissions. Nice.

This matches my understanding as well.

The only caveat is there's an open question about whether we need to bring lifecycle hooks back to help ensure graceful agent termination in some non-scale down situations (AZ rebalancing, with mixed on-demand/spot ASGs when some on-demand instances should be terminated and replaced with spot, etc).

I think this PR is fine though - we can restore the permissions if we ever decide to add lifecycle hooks back in.

@chloeruka chloeruka merged commit 311746b into master Apr 28, 2021
@chloeruka chloeruka deleted the iam-remove-sns-sqs branch April 28, 2021 02:38
@chloeruka chloeruka mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants