Specify asg perm resources in InstancePolicy #800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I updated the
InstancePolicy
to match theResources
of theAsgProcessSuspenderRole
'sAsgProcessModification
policy.elastic-ci-stack-for-aws/templates/aws-stack.yml
Lines 1038 to 1041 in b84d760
Notes
The
InstancePolicy
could be further cut down.For example, do we use
sqs
orsns
anymore ?elastic-ci-stack-for-aws/templates/aws-stack.yml
Lines 730 to 735 in b84d760
According to the 5.2.0's IAMRole's AccessAdvisor tab in AWS, it shows that the following are unused
It would be good to pair these (and other?) IAM changes with the permission boundary PR #767.