Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify asg perm resources in InstancePolicy #800

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

nitrocode
Copy link
Contributor

@nitrocode nitrocode commented Feb 19, 2021

What

I updated the InstancePolicy to match the Resources of the AsgProcessSuspenderRole's AsgProcessModification policy.

- Effect: Allow
Action:
- 'autoscaling:SuspendProcesses'
Resource: !Sub arn:${AWS::Partition}:autoscaling:${AWS::Region}:${AWS::AccountId}:autoScalingGroup:*:autoScalingGroupName/${AWS::StackName}-AgentAutoScaleGroup-*

Notes

The InstancePolicy could be further cut down.

For example, do we use sqs or sns anymore ?

- Effect: Allow
Action:
- sqs:*
- sns:Unsubscribe
- sns:Subscribe
Resource: "*"

According to the 5.2.0's IAMRole's AccessAdvisor tab in AWS, it shows that the following are unused

  • Amazon EC2 (InstancePolicy)
  • Amazon CloudWatch (InstancePolicy)
  • AWS CloudFormation (InstancePolicy)
  • Amazon SQS (InstancePolicy)
  • Amazon SNS (InstancePolicy)

It would be good to pair these (and other?) IAM changes with the permission boundary PR #767.

@keithduncan keithduncan merged commit 7539344 into buildkite:master Aug 30, 2021
@nitrocode nitrocode deleted the patch-5 branch September 24, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants