Use the docker directory to check for disk space #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some people might use a RAM drive for docker to get better performance. By specifying the docker dir, we make sure we are checking for disk space in the right filesystem.
|
@lox what's the status of this PR. It seems like a very simple change. Is there something I'm missing? Anything you want me to fix? |
|
Apologies, I was thinking it over! Let's do it. Did you end up figuring out how to reliably override those env per-build? |
|
Are you referring to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people might use a RAM drive for docker to get better performance. By specifying the docker dir, we make sure we are checking for disk space in the right filesystem.