Try harder to delete test S3 logging buckets created during CI #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create three CloudFormation Stacks on each build of the elastic stack, confirming instances boot and work as expected. There are specific steps in the build that attempt to delete all resources created for those tests, but from time to time they can fail. This cleanup step runs at the end of the build and will delete any resources this pipeline might've left behind, regardless of whether they were created in this specific build or not. I noticed that the AWS Account these test stacks were created in had many old S3 buckets like this: * buildkite-aws-stack-test--managedsecretsloggingbuc-XXXXXXXXX These are the logging buckets created by test stacks to holds access logs for the matching secrets S3 bucket. We attempt to delete them in `.buildkite/steps/delete.sh`, but some slip through the net. This should help ensure we pick them up on a future build, and avoid the account growing an unbounded number of these buckets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create three CloudFormation Stacks on each build of the elastic stack, confirming instances boot and work as expected. There are specific steps in the build that attempt to delete all resources created for those tests, but from time to time they can fail.
This cleanup step runs at the end of the build and will delete any resources this pipeline might've left behind, regardless of whether they were created in this specific build or not.
I noticed that the AWS Account these test stacks were created in had many old S3 buckets like this:
These are the logging buckets created by test stacks to holds access logs for the matching secrets S3 bucket. We attempt to delete them in
.buildkite/steps/delete.sh, but some slip through the net.This should help ensure we pick them up on a future build, and avoid the account growing an unbounded number of these buckets.