Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't (re)install docker (on Windows) #1136

Conversation

triarius
Copy link
Contributor

@triarius triarius commented Jun 14, 2023

The way we were installing Docker EE has stopped working. But, it seems to already be installed in the base AMI.

It seems to already be installed in the base AMI
@triarius triarius requested a review from a team June 14, 2023 03:59
@triarius triarius changed the title Don't install docker Don't install docker (on Windows) Jun 14, 2023
@triarius triarius force-pushed the pdp-1120-installing-docker-on-elastic-ci-stack-no-longer-works-in branch from f303b23 to c32556c Compare June 14, 2023 06:30
@triarius triarius changed the title Don't install docker (on Windows) Don't (re)install docker (on Windows) Jun 14, 2023
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! ❇️

Copy link
Member

@sj26 sj26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@@ -51,6 +51,7 @@ steps:
command:
- git --version
- docker info
- docker run --rm mcr.microsoft.com/windows/nanoserver:ltsc2019 cmd.exe /c echo hello
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@triarius triarius merged commit 94ce9d2 into master Jun 15, 2023
@triarius triarius deleted the pdp-1120-installing-docker-on-elastic-ci-stack-no-longer-works-in branch June 15, 2023 03:34
@triarius triarius mentioned this pull request Jun 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants