Rename the parameter EnableGitMirrorsExperiment to BuildkiteAgentEnableGitMirrors
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
force-pushed
the
oss-315-git-mirrors-only-works-as-an-experment
branch
from
6ada5ca to
0c4f8fe
Compare
triarius
changed the title
EnableAgentGitMirrorsExperiment parameter and create dirs for git mirrors by defaultEnableGitMirrorsExperiment to BuildkiteAgentEnableGitMirrors
triarius
force-pushed
the
oss-315-git-mirrors-only-works-as-an-experment
branch
from
0c4f8fe to
bfe167a
Compare
…nableGitMirrors` And no longer set the experiment in the agent config. Now that the experiment has been mainlined, this feature is toggled by the non emptiness of the `git-mirrors-path` config value. So all we need to do is ensure that if the new parameter is true, it is set to a non-empty value (and the path exists and is writable by the agent). Fixes: #1121
triarius
force-pushed
the
oss-315-git-mirrors-only-works-as-an-experment
branch
from
bfe167a to
028ce2b
Compare
triarius
force-pushed
the
oss-315-git-mirrors-only-works-as-an-experment
branch
3 times, most recently
from
729939d to
7b874c7
Compare
Merged
triarius
added a commit
that referenced
this pull request
Jun 21, 2023
This keeps the parameter name, but otherwise is the same as #1123
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And no longer set the experiment in the agent config. Now that the
experiment has been mainlined, this feature is toggled by the non
emptiness of the
git-mirrors-pathconfig value. So all we need to do isensure that if the new parameter is true, it is set to a non-empty value
(and the path exists and is writable by the agent).
Fixes: #1121