Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a parameter for buildkite-agent-scaler edititon and version #1104

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

triarius
Copy link
Contributor

@triarius triarius commented Apr 3, 2023

This will allow using a development version of the buildkite-agent-scaler with the elastic-ci-stack. To allow customers to use in all our supported regions, the pipeline needs to be run with the environment variable COPY_TO_ALL_REGIONS=true.

@triarius triarius requested a review from a team April 3, 2023 05:02
@triarius triarius force-pushed the pdp-298-make-it-easier-to-substitute-the branch from 713b590 to 90c94f4 Compare April 3, 2023 09:41
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@triarius triarius merged commit 16a3f45 into master Apr 4, 2023
@triarius triarius deleted the pdp-298-make-it-easier-to-substitute-the branch April 4, 2023 01:05
triarius added a commit that referenced this pull request Apr 23, 2023
\## [v5.19.0](https://github.com/buildkite/elastic-ci-stack-for-aws/tree/v5.19.0) (2023-04-24)
[Full Changelog](v5.18.0...v5.19.0)

\### Added
- A parameter for buildkite-agent-scaler edition and version [#1104](#1104) (@triarius)

\### Fixed
- Stack failed to create because it tried to create an ACL on S3 [#1109](#1109) (@saviogl)
@triarius triarius mentioned this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants