Add docker compose v2 to linux #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donbobka
force-pushed
the
add-docker-compose-v2
branch
from
2cbff62 to
8dc7c02
Compare
|
Any update here? The check is still pending. |
|
I believe github can get stuck sometimes. If you While I'm here I'll mention that I'm very keen on this PR being merged! |
triarius
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
@donbobka Thanks for your PR! Not sure what happened with the webhook, so copied your changes into a branch and sheparded it through buildkite's CI: master...triarius/test-dcv2
Long and short of it is it looks good 🪅 Please accept the version bump and we will merge.
Co-authored-by: Narthana Epa <narthana.epa@gmail.com>
|
@triarius Question for you: once this is merged, how soon after could we expect a new release containing the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #1022 docker compose v2 can coexist with v1 +
docker-compose-pluginnow supports opt-in feature to enable docker-compose v2