Add support for elastic APM tracer
#1551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for tracing via Elastic APM using the OpenTracing framework. \## Why? Adding support for Elastic APM provides users with an alternative backend to visualise Job failures, metrics etc. \## Changes * Add support for the `elastic` tracing backend using the `go.elastic.co/apm` package. * Ran `go mod tidy` to fix some `go.mod` issues.
|
This could be superceded by #1548... |
|
Thanks very much @fatmcgav 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for tracing via Elastic APM using the OpenTracing framework.
Why?
Adding support for Elastic APM provides users with an alternative backend to visualise Job failures, metrics etc.
Credit to @goodspark for putting the initial OpenTracing framework in-place. That made this implementation very simple :)
Changes
elastictracing backend using thego.elastic.co/apmpackage.go mod tidyto fix somego.modissues.agent.BuildVersion()as part of theStarting buildkite-agent...log line for better visibility.Examples
This shows a simple "Hello World" job that clones a specific Git repo and then runs a command.
A failed job with associated error events.