Skip to content

fix: ignore shellcheck issues as expected #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

fix: ignore shellcheck issues as expected #271

merged 1 commit into from
Sep 2, 2025

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Sep 2, 2025

Changes

  • Ignore SC2329 as signal function

@mcncl
fix: ignore shellcheck issues as expected
8c30980 
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
@mcncl mcncl requested a review from a team as a code owner September 2, 2025 00:43
@scadu
Copy link
Contributor

scadu commented Sep 2, 2025

shellcheck disable=2317 shouldn't be needed anymore.
As for the SC2329, seems reasonable considering ShellCheck's shortcomings:

ShellCheck is currently bad at figuring out functions that are invoked via trap. In such cases, please ignore the message with a directive.

Source: https://www.shellcheck.net/wiki/SC2329

@mcncl mcncl merged commit d06896f into master Sep 2, 2025
1 check passed
@mcncl mcncl deleted the fix/shellcheck_issue branch September 2, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scadu scadu scadu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcncl @scadu