Add --skip-pull support to v2 run command #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `docker-compose` plugin currently seems to ignore the `skip-pull`
option. For example, this configuration:
```
steps:
- command: bundle exec rubocop
plugins:
- docker-compose#v4.14.0:
run: ruby
skip-pull: true
config: docker-compose.yml
cli-version: 2
```
Results in a command that includes the `--pull` flag, something like
this:
```
docker compose -f docker-compose.yml -p buildkite0123456789 build --pull ruby
```
This PR updates run.sh to fully support the `skip-pull` option. The
same configuration as above now results in the `--pull` flag being
omitted from the generated command:
```
docker compose -f docker-compose.yml -p buildkite0123456789 build ruby
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker-composeplugin currently seems to ignore theskip-pulloption. For example, this configuration:Results in a command that includes the
--pullflag, something like this:This PR updates run.sh to fully support the
skip-pulloption. The same configuration as above now results in the--pullflag being omitted from the generated command: