Collapse logging of run output by default #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoiscampbell
changed the title
francoiscampbell
force-pushed
the
collapse-args
branch
from
8212330 to
2b30650
Compare
francoiscampbell
force-pushed
the
collapse-args
branch
from
2b30650 to
1bfc082
Compare
pzeballos
reviewed
Oct 12, 2023
pzeballos
requested changes
Oct 12, 2023
Contributor
pzeballos
left a comment
pzeballos
left a comment
There was a problem hiding this comment.
Thanks @francoiscampbell! I think this is reasonable, but you are changing the default behavior, if the default kept the current functionality will be ok to merge (and update the test 🙂 )
Contributor
Author
|
Ok @pzeballos, I've flipped the default. Are we OK with the default being inconsistent between this plugin and the Docker one? |
francoiscampbell
force-pushed
the
collapse-args
branch
from
f83ba32 to
10b47e7
Compare
Contributor
yep, all good, they are different plugins, and we prefer not to do a backwards compatibility change at the moment :) The build is failing in the linter step @francoiscampbell , can you update the Readme to use v4.15.0? Thanks! |
Contributor
Author
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default this plugin collects the run output in a
+++group, while thedockerplugin collects it in a---group (https://github.com/buildkite-plugins/docker-buildkite-plugin/blob/36b85cc317745f868f2f6918a02f9cfb6a0b3069/commands/run.sh#L503). This PR unifies the two plugins by switching to using---by default.The rationale for using
---by default is that when we're passing lots of environment variables, volumes, etc, thedocker-compose run ...command gets pretty long and having the log group expanded by default is noisy. Additionally, it's quite likely that the command being run will create a+++group of its own, so it's not necessary for the plugin to provide one by default.For backwards compatibility, the
collapse-run-log-groupoption has been added, which will restore the old behaviour.