Warnings with step-level array commands #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on previous discussions (#59, #186 and #312), this plugin does not support step-level commands defined as an array. We just receive a multi-line string in the
BUILDKITE_COMMANDvariable but there is no way to identify it is because a single command with newlines (like we test in the pipeline) or an actual array to be able to manipulate the string and do what we are supposed to do (like what the agent does: creates a script enclosing the whole command and runs that script instead).So the only possible alternative is to add a warning to the documentation and output for people to be aware of the existing limitation 🤷
Closes #312