Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IfcFontWeight.md #834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KnutHelland
Copy link

bold is not an allowed value according to WHERE-rule WR1.

`bold` is not an allowed value according to WHERE-rule WR1.
@aothms
Copy link
Collaborator

aothms commented Apr 29, 2024

How about updating the rule. I noticed small-caps is in the rule, which is not a weight, but a variant.

SVG (didn't check version) that we claim to be reference suggests: normal | bold | bolder | lighter | [<number>].

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/font-weight

My preference would be to strictly follow SVG.

@KnutHelland
Copy link
Author

@aothms I don't know the process here. I hoped that it was possible to update the documentation for the already released IFC4X3_ADD2 schema. We can't change the schema, but I thought it was possible to correct wrong information in the documentation?

I agree that for future schema releases, it could be a good idea to change the where rule, but that should probably be a separate discussion, and should not slow down the process of just fixing this contradiction in the docs for the released schema. 🤔

@berlotti berlotti requested review from berlotti and aothms May 16, 2024 07:25
Copy link
Member

@berlotti berlotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to fix inconsistencies between rule and documentation.
Next version we should change the rule.

@berlotti berlotti requested a review from evandroAlfieri May 16, 2024 07:41
@@ -3,7 +3,6 @@
The _IfcFontWeight_ type defines the weight of the font. Values are:

* normal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* normal
* normal
* small-caps [DEPRECATED]

If we want correspondence with the formal rule we need to add small-caps. But if you don't mind I'll add a deprecated label next to it (we don't have that formally since this is just a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants