-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IfcFontWeight.md #834
base: master
Are you sure you want to change the base?
Conversation
`bold` is not an allowed value according to WHERE-rule WR1.
How about updating the rule. I noticed SVG (didn't check version) that we claim to be reference suggests: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/font-weight My preference would be to strictly follow SVG. |
@aothms I don't know the process here. I hoped that it was possible to update the documentation for the already released IFC4X3_ADD2 schema. We can't change the schema, but I thought it was possible to correct wrong information in the documentation? I agree that for future schema releases, it could be a good idea to change the where rule, but that should probably be a separate discussion, and should not slow down the process of just fixing this contradiction in the docs for the released schema. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to fix inconsistencies between rule and documentation.
Next version we should change the rule.
@@ -3,7 +3,6 @@ | |||
The _IfcFontWeight_ type defines the weight of the font. Values are: | |||
|
|||
* normal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* normal | |
* normal | |
* small-caps [DEPRECATED] |
If we want correspondence with the formal rule we need to add small-caps
. But if you don't mind I'll add a deprecated label next to it (we don't have that formally since this is just a string.
bold
is not an allowed value according to WHERE-rule WR1.