Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ifcGuid is specified as "optional" in BCF-API documentation #205

Closed
rahulsule opened this issue Jun 24, 2020 · 4 comments · Fixed by #256
Closed

ifcGuid is specified as "optional" in BCF-API documentation #205

rahulsule opened this issue Jun 24, 2020 · 4 comments · Fixed by #256
Assignees
@ykulbak
Milestone
V3.0

Comments

@rahulsule
Copy link
Contributor

This page Component specification in BCF-API specifies ifcGuid as optional whereas BCF-XML documentation specifies it as mandatory.
@ykulbak ykulbak self-assigned this Nov 9, 2020
@ykulbak
Copy link
Collaborator

ykulbak commented Nov 9, 2020

Resolve in a manner consistent with buildingSMART/BCF-XML#228

@ykulbak ykulbak added this to the V2.2 milestone Nov 9, 2020
ykulbak added a commit that referenced this issue Nov 16, 2020
@ykulbak
Clarify Component Identification
88500db 
See #205 and buildingSMART/BCF-XML#228
@ykulbak ykulbak mentioned this issue Nov 16, 2020
Closed
@ykulbak ykulbak linked a pull request Nov 16, 2020 that will close this issue
Clarify Component Identification #235
Closed
@leosobral
Copy link
Contributor

Discussed in BCF hackathon and agree to improve the doc of BCF-API, I will provide a PR

@ykulbak ykulbak modified the milestones: V2.2, V3.0 Nov 25, 2020
@leosobral
Copy link
Contributor

PR: #256

@ykulbak ykulbak linked a pull request Nov 25, 2020 that will close this issue
Clarify ifc_guid as optional in docs #256
Merged
ykulbak pushed a commit that referenced this issue Nov 27, 2020
@leosobral
#205 Clarify component identification
6d293c2 
Made it consistent with latest BCF-XML specification.
@ykulbak
Copy link
Collaborator

ykulbak commented Nov 27, 2020

Closed by #256

@ykulbak ykulbak closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ykulbak ykulbak

Labels
None yet
Projects
None yet
Milestone
V3.0
3 participants
@ykulbak @leosobral @rahulsule