Skip to content

Commit

Permalink
Merge pull request #234 from buildingSMART/155_remove_reply_to_comment
Browse files Browse the repository at this point in the history
Remove reply_to_comment_guid from comment schema.
  • Loading branch information
jasollien authored Nov 23, 2020
2 parents 351a3a4 + f7b9816 commit 704a25c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 24 deletions.
19 changes: 7 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ at the project level. The available actions include:

* *update* - The ability to update the project details (see [4.1.3 PUT Project Service](#413-put-project-service))
* *createTopic* - The ability to create a new topic (see [4.2.2 POST Topic Service](#422-post-topic-service))
* *createDocument* - The ability to create a new document (see [4.8.2 POST Document Service](#492-post-document-service))
* *createDocument* - The ability to create a new document (see [4.8.2 POST Document Service](#482-post-document-service))

#### 4.1.5.2 Topic

Expand All @@ -667,9 +667,9 @@ level by default (i.e. unless overridden by specific topics) The available actio

* *update* - The ability to update the topic (see [4.2.4 PUT Topic Service](#424-put-topic-service))
* *updateBimSnippet* - The ability to update the BIM snippet for topics (see [4.2.7 PUT Topic BIM Snippet Service](#427-put-topic-bim-snippet-service))
* *updateRelatedTopics* - The ability to update the collection of related topics (see [4.6.2 PUT Related Topics Service](#472-put-related-topics-service))
* *updateDocumentReferences* - The ability to update the collection of document references (see [4.7.3 PUT Document Reference Service](#483-put-document-reference-service))
* *updateFiles* - The ability to update the file header (see [4.3.2 PUT Files (Header) Service](#432-put-files-header-service))
* *updateRelatedTopics* - The ability to update the collection of related topics (see [4.6.2 PUT Related Topics Service](#462-put-related-topics-service))
* *updateDocumentReferences* - The ability to update the collection of document references (see [4.7.3 PUT Document Reference Service](#473-put-document-reference-service))
* *updateFiles* - The ability to update the file header (see [4.3.3 PUT Files (Header) Service](#433-put-files-header-service))
* *createComment* - The ability to create a comment (see [4.4.2 POST Comment Service](#442-post-comment-service))
* *createViewpoint* - The ability to create a new viewpoint (see [4.5.2 POST Viewpoint Service](#452-post-viewpoint-service))

Expand Down Expand Up @@ -1213,9 +1213,8 @@ JSON encoded body using the "application/json" content type.
|Parameter|Type|Description|Required|
|---------|----|-----------|--------|
|guid|string|The desired guid|false|
|comment|string|The comment text|true|
|viewpoint_guid|string|The GUID of the related viewpoint|false|
|reply_to_comment_guid|string|GUID of the comment to which this comment replies to|false|
|comment|string|The comment text, can't be empty when provided|true, if `viewpoint_guid` is not provided|
|viewpoint_guid|string|The GUID of the related viewpoint|true, if `comment` is not provided|

**Example Request**

Expand Down Expand Up @@ -2468,8 +2467,6 @@ Retrieve a **collection** of comment events related to a project (default sort o
|comment_text_updated|The comment text(limit: 1024 characters)|
|viewpoint_updated|The viewpoint guid|
|viewpoint_removed|null|
|reply_to_comment_updated|The reply to comment guid|
|reply_to_comment_removed|null|

**Odata filter parameters**

Expand Down Expand Up @@ -2541,7 +2538,7 @@ Get events that are of type 'comment_created', or 'viewpoint_updated'

[comment_event_GET.json](Schemas_draft-03/Collaboration/Events/comment_event_GET.json)

Retrieve a **collection** of comment events related to a comment (default sort order is `date`).
Retrieve a **collection** of comment events related to a single comment (default sort order is `date`).

**Comment event types**

Expand All @@ -2551,8 +2548,6 @@ Retrieve a **collection** of comment events related to a comment (default sort o
|comment_text_updated|The comment text(limit: 1024 characters)|
|viewpoint_updated|The viewpoint guid|
|viewpoint_removed|null|
|reply_to_comment_updated|The reply to comment guid|
|reply_to_comment_removed|null|

**Odata filter parameters**

Expand Down
4 changes: 0 additions & 4 deletions Schemas_draft-03/Collaboration/Comment/comment_GET.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@
"type": ["string",
"null"]
},
"reply_to_comment_guid": {
"type": ["string",
"null"]
},
"modified_date": {
"type": ["string",
"null"]
Expand Down
4 changes: 0 additions & 4 deletions Schemas_draft-03/Collaboration/Comment/comment_POST.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
"viewpoint_guid": {
"type": ["string",
"null"]
},
"reply_to_comment_guid": {
"type": ["string",
"null"]
}
}
}
4 changes: 0 additions & 4 deletions Schemas_draft-03/Collaboration/Comment/comment_PUT.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
"viewpoint_guid": {
"type": ["string",
"null"]
},
"reply_to_comment_guid": {
"type": ["string",
"null"]
}
}
}

0 comments on commit 704a25c

Please sign in to comment.